[webkit-reviews] review granted: [Bug 89241] Align RenderLayer's descendant dependent flags semantics : [Attachment 147892] Proposed change v1.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 89241: Align RenderLayer's descendant dependent flags semantics
https://bugs.webkit.org/show_bug.cgi?id=89241

Attachment 147892: Proposed change v1.
https://bugs.webkit.org/attachment.cgi?id=147892&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147892&action=review


> Source/WebCore/ChangeLog:16
> +	   Changed this method to not take a boolean as every callers where
passing

"as every caller was passing"

> Source/WebCore/rendering/RenderLayer.cpp:648
> +	       sc->dirtyZOrderLists();
> +	       if (sc->hasVisibleContent())

I'd like to see a comment explaining why z-order lists are dirtied. I think we
also don't omit hidden layers from the z-order lists when compositing, so you
may be able to avoid this dirty in some cases.