[webkit-reviews] review canceled: [Bug 20840] Wrong collapsing border resolution when a table has cells with different colspans : [Attachment 128799] Rebased patch to get EWS coverage.

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 20840: Wrong collapsing border resolution when a table has cells with
different colspans
https://bugs.webkit.org/show_bug.cgi?id=20840

Attachment 128799: Rebased patch to get EWS coverage.
https://bugs.webkit.org/attachment.cgi?id=128799&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128799&action=review


>> Source/WebCore/rendering/RenderTableCell.cpp:571
>> +bool
RenderTableCell::considerCellForBeforeAfterCollapsingBorderResolution(const
RenderTableCell* neightborCell) const
> 
> typo: should be neighbourCell

Good catch.

>> Source/WebCore/rendering/RenderTableCell.cpp:587
>> +	if (prevCell &&
considerCellForBeforeAfterCollapsingBorderResolution(prevCell)) {
> 
> maybe cellBorderAlignedWith() ? The function name does seem too long.

cellBorderAlignedWith is imprecise: we are only taking the block flow direction
borders into account, not the inline base direction. Maybe
areCellBeforeAfterBorderAlignedWith() or areCellBlockFlowDirectionAligned()
would be better and a bit shorter.