[webkit-reviews] review denied: [Bug 88287] JSC: need to implement IDBKeyPathBackendImpl to make indexedDB for JSC. : [Attachment 148320] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 10:37:16 PDT 2012


Oliver Hunt <oliver at apple.com> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 88287: JSC: need to implement IDBKeyPathBackendImpl to make indexedDB for
JSC.
https://bugs.webkit.org/show_bug.cgi?id=88287

Attachment 148320: Patch
https://bugs.webkit.org/attachment.cgi?id=148320&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
You shouldn't be using a temporary context --  why are we serializing to one
form when we want another?  Alternatively why are we deserializing?

If it's absolutely critical we should either add logic to deserialize directly
to IDB types, or not be serializing to an unrelated format in the first place.


More information about the webkit-reviews mailing list