[webkit-reviews] review denied: [Bug 89421] [CSSRegions]Change WEBKIT_REGION_RULE value to 16 : [Attachment 148326] patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Andrei Onea <onea at adobe.com>'s
request for review:
Bug 89421: [CSSRegions]Change WEBKIT_REGION_RULE value to 16
https://bugs.webkit.org/show_bug.cgi?id=89421

Attachment 148326: patch
https://bugs.webkit.org/attachment.cgi?id=148326&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148326&action=review


Just some minor nits to make sure we don't make mistakes in the future.

> Source/WebCore/css/StyleRule.h:48
> -	   Region
> +	   Region = 16

If it's important for these to be kept in sync with the values in CSSRule.h,
you could use a COMPILE_ASSERT.  E.g., in CSSRule.cpp,
COMPILE_ASSERT(StyleRule::Region == CSSRule::WEBKIT_REGION_RULE,
enums_should_match);.

> Source/WebCore/css/StyleRule.h:87
> -    unsigned m_type : 4;
> -    signed m_sourceLine : 28;
> +    unsigned m_type : 5;
> +    signed m_sourceLine : 27;

Can you add a compile assert for the size in StyleRule.cpp? See CSSRule.cpp for
an example.