[webkit-reviews] review granted: [Bug 89220] Adds DeviceMotionClientMock : [Attachment 147833] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 08:24:24 PDT 2012


Steve Block <steveblock at google.com> has granted Amy Ousterhout
<aousterh at chromium.org>'s request for review:
Bug 89220: Adds DeviceMotionClientMock
https://bugs.webkit.org/show_bug.cgi?id=89220

Attachment 147833: Patch
https://bugs.webkit.org/attachment.cgi?id=147833&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147833&action=review


r=me

> Source/WebCore/platform/mock/DeviceMotionClientMock.h:52
> +    virtual void deviceMotionControllerDestroyed() OVERRIDE { }

Maybe add a comment about why we don't need to do anything here


More information about the webkit-reviews mailing list