[webkit-reviews] review denied: [Bug 89464] Web Inspector: Clicking "Clear all profiles" while ongoing recording should reset the ProfileLauncherView : [Attachment 148318] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 19 06:04:43 PDT 2012
Yury Semikhatsky <yurys at chromium.org> has denied Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 89464: Web Inspector: Clicking "Clear all profiles" while ongoing recording
should reset the ProfileLauncherView
https://bugs.webkit.org/show_bug.cgi?id=89464
Attachment 148318: Patch
https://bugs.webkit.org/attachment.cgi?id=148318&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148318&action=review
> Source/WebCore/inspector/front-end/ProfilesPanel.js:381
> + this.recordButton.title = "";
Could you call toggleRecordButton instead if we are currently profiling the
page to leave correct button title?
More information about the webkit-reviews
mailing list