[webkit-reviews] review canceled: [Bug 89439] [Forms] Make step action of SpinButtonElement replaceable : [Attachment 148290] Patch 2

[bugzilla-daemon at webkit.org]

yosin at chromium.org has canceled yosin at chromium.org's request for review:
Bug 89439: [Forms] Make step action of SpinButtonElement replaceable
https://bugs.webkit.org/show_bug.cgi?id=89439

Attachment 148290: Patch 2
https://bugs.webkit.org/attachment.cgi?id=148290&action=review

------- Additional Comments from yosin at chromium.org
View in context: https://bugs.webkit.org/attachment.cgi?id=148290&action=review


> Source/WebCore/html/InputType.h:299
> +    void stepUpFromRenderer(int);

We should move stepUpFromRenderer to TextFieldInputType, because only
TextFieldInputType uses it.
Note: We need to expose applyStep as protected for this.

> Source/WebCore/html/shadow/TextControlInnerElements.h:101
> +	   virtual void spinButtonStepDown() = 0;

We should have virtual destructor, clang issues warning for this.