[webkit-reviews] review requested: [Bug 89439] [Forms] Make step action of SpinButtonElement replaceable : [Attachment 148290] Patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 19 02:18:30 PDT 2012
yosin at chromium.org has asked for review:
Bug 89439: [Forms] Make step action of SpinButtonElement replaceable
https://bugs.webkit.org/show_bug.cgi?id=89439
Attachment 148290: Patch 2
https://bugs.webkit.org/attachment.cgi?id=148290&action=review
------- Additional Comments from yosin at chromium.org
Could you review this patch?
Thanks in advance.
= Changes since last patch =
* Rename SpinButtonElement::Callback to StepActionHandler
* SpinButtonElement keeps m_stepActionHandler as pointer and checks it isn't
nullptr before calling action.
* Add SpinButtonElement::removeStepActionHandler
** This method will be called from TextFieldInputType dtor and
destroyShadowSubtree
More information about the webkit-reviews
mailing list