[webkit-reviews] review denied: [Bug 89107] Web Inspector: Allow module injections into the InjectedScript : [Attachment 148243] =Another API proposal

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 89107: Web Inspector: Allow module injections into the InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=89107

Attachment 148243: =Another API proposal
https://bugs.webkit.org/attachment.cgi?id=148243&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148243&action=review


> Source/WebCore/inspector/InjectedScript.h:107
> +	 virtual void visitArguments(ScriptCallArgumentHandler&) = 0;

This API looks awkward to me, why not have just callModuleFunction(moduleName,
functionName, arguments) method on InjectedScript? Can you describe what kind
of modules do you need? Are they going to have some fixed API like
InjectedScript or they may some random objects with a set of methods? Will they
need to access injected script structures?