[webkit-reviews] review granted: [Bug 78127] REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory : [Attachment 148204] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 78127: REGRESSION (NRWT): Results for new non-text-only tests are always
put in the most-specific platform directory
https://bugs.webkit.org/show_bug.cgi?id=78127

Attachment 148204: Patch
https://bugs.webkit.org/attachment.cgi?id=148204&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148204&action=review


> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:284
> +	   optparse.make_option("--add-platform-exceptions",
action="store_true", default=False,

I would have named this flag --use-most-specific-directory or
--use-version-directory. I don't understand what "exceptions" you're referring
here.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:977
> +	   # Test that we update the platform expectations in the
version-specific dirs

Nit: Please spell out directories.