[webkit-reviews] review granted: [Bug 67935] webkit-patch should add reviewer if "Reviewed by NOBODY (OOPS!)." is missing : [Attachment 148102] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 00:59:03 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Balazs Ankes
<bank at inf.u-szeged.hu>'s request for review:
Bug 67935: webkit-patch should add reviewer if "Reviewed by NOBODY (OOPS!)." is
missing
https://bugs.webkit.org/show_bug.cgi?id=67935

Attachment 148102: proposed fix
https://bugs.webkit.org/attachment.cgi?id=148102&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148102&action=review


> Tools/Scripts/webkitpy/common/checkout/changelog.py:358
> +	       bug_url_number_of_items =
len(re.findall(config_urls.bug_url_long, latest_entry, re.MULTILINE))
> +	       bug_url_number_of_items +=
len(re.findall(config_urls.bug_url_short, latest_entry, re.MULTILINE))

Please add a test case when we have multiple bug URLs before you land.


More information about the webkit-reviews mailing list