[webkit-reviews] review denied: [Bug 88952] Move setDefersLoading to Internals interface : [Attachment 147226] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 00:54:41 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 88952: Move setDefersLoading to Internals interface
https://bugs.webkit.org/show_bug.cgi?id=88952

Attachment 147226: Patch
https://bugs.webkit.org/attachment.cgi?id=147226&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147226&action=review


> Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm:-492
> -    [[mainFrame webView] setDefersCallbacks:defers];

Unfortunately this API has non-DRT clients such as
_documentFragmentFromPasteboard in WebHTMLView.mm.
We should probably add some WebKit API test for this before removing the
dependency.


More information about the webkit-reviews mailing list