[webkit-reviews] review requested: [Bug 89425] [Forms] Move isKeyboardFocusable and isMouseFocusable to InputType from HTMLInputElement : [Attachment 148270] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 00:15:03 PDT 2012


yosin at chromium.org has asked  for review:
Bug 89425: [Forms] Move isKeyboardFocusable and isMouseFocusable to InputType
from HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=89425

Attachment 148270: Patch 2
https://bugs.webkit.org/attachment.cgi?id=148270&action=review

------- Additional Comments from yosin at chromium.org
Could you review this patch?
Thanks in advance.

= Changes since last review ==
* Remove "virtual" from isTextFormControl*Focusable method declarations
** as suggested
* Call InputType::isKeyboardFocusable() in RadioInputType::isKeyboardFocusable
** as suggested


More information about the webkit-reviews mailing list