[webkit-reviews] review denied: [Bug 89435] [GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild : [Attachment 148264] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 89435: [GTK] Don't run the tests with jhbuild wrapper if it's already
running under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=89435

Attachment 148264: Patch
https://bugs.webkit.org/attachment.cgi?id=148264&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
This breaks usecases where users want to use the WebKit jhbuild, but are
already in another jhbuild shell. Tests aren't expected to pass outside the
WebKit jhbuild anyhow.

I think it would be better to simply make the scripts not use JHbuild if
update-webkitgtk-libs has never been run.