[webkit-reviews] review denied: [Bug 89425] [Forms] Move isKeyboardFocusable and isMouseFocusable to InputType from HTMLInputElement : [Attachment 148261] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 89425: [Forms] Move isKeyboardFocusable and isMouseFocusable to InputType
from HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=89425

Attachment 148261: Patch 1
https://bugs.webkit.org/attachment.cgi?id=148261&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148261&action=review


> Source/WebCore/html/HTMLInputElement.h:267
> +    virtual bool isTextFormControlFocusable() const;
> +    virtual bool isTextFormControlKeyboardFocusable(KeyboardEvent*) const;
> +    virtual bool isTextFormControlMouseFocusable() const;

They shouldn't be virtual.
Also, please put them just below setValueInternal() because it is also a helper
for *InputType.

> Source/WebCore/html/RadioInputType.cpp:119
> +    if (!element()->isTextFormControlKeyboardFocusable(event))

if (!InputType::isKeyboardFocusable(event))
is better.