[webkit-reviews] review granted: [Bug 67582] Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse() : [Attachment 148104] put WTF_USE_CG back, this should build now

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Yong Li <yoli at rim.com>'s request
for review:
Bug 67582: Calling nativeImageForCurrentFrame() causes assertion failure:
m_verifier.isSafeToUse()
https://bugs.webkit.org/show_bug.cgi?id=67582

Attachment 148104: put WTF_USE_CG back, this should build now
https://bugs.webkit.org/attachment.cgi?id=148104&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148104&action=review


This should do it.

Congrats to all! :)

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:-1159

> -    if (!img || !img->data())

!img->data() got dropped but that seems ok.

> Source/WebKit/efl/ewk/ewk_history.cpp:341
>	   ERR("icon is NULL.");

This error got a little bit broader.

Before if icon->nativeImageForCurrentFrame(); returned 0 this error wasn't
printed.

But I think this is ok (in all instances).

> Source/WebKit/efl/ewk/ewk_history.cpp:353
>	   ERR("icon is NULL.");

Same comment as above.

> Source/WebKit/efl/ewk/ewk_settings.cpp:218
>	   ERR("no icon for url %s", url);

Same comment as before.

> Source/WebKit/efl/ewk/ewk_settings.cpp:232
>	   ERR("no icon for url %s", url);

Same comment as before.