[webkit-reviews] review denied: [Bug 88321] [Qt][Win] Fix broken QtWebKit5.lib linking : [Attachment 147360] Patch

[bugzilla-daemon at webkit.org]

Kevin Ollivier <kevino at theolliviers.com> has denied Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 88321: [Qt][Win] Fix broken QtWebKit5.lib linking
https://bugs.webkit.org/show_bug.cgi?id=88321

Attachment 147360: Patch
https://bugs.webkit.org/attachment.cgi?id=147360&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
I'm not sure about the QT side of the build, but I do not think these macros
are correct for wx. The WTF/JS_EXPORT macros are for dynamic libraries only,
not static, so macros with names like STATICALLY_LINKED_WITH_WTF are confusing.
On the wx port, we simply use export macros when building JSCore and WTF, which
is what the defines for our port indicate and does not need changed. I don't
know enough about the QT build to say what precisely is going wrong, but it
sounds like either the .dll is not importing all symbols from the static
library, or there are both static and dynamic build configs for QTWebKit and
the scripts are not adjusting the build configurations accordingly.