[webkit-reviews] review granted: [Bug 87844] Implement painting slider tick marks : [Attachment 148234] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 87844: Implement painting slider tick marks
https://bugs.webkit.org/show_bug.cgi?id=87844

Attachment 148234: Patch
https://bugs.webkit.org/attachment.cgi?id=148234&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148234&action=review


Almost ok.
But please do not commit this patch until resolving the <datalist> update
issue.

> Source/WebCore/platform/qt/RenderThemeQt.cpp:412
> +IntSize RenderThemeQt::sliderTickSize() const
> +{
> +    return IntSize(0, 0);
> +}
> +
> +int RenderThemeQt::sliderTickOffsetFromTrackCenter() const
> +{
> +    return 0;
> +}
> +

Need to wrap by #if ENABLE(DATALIST) - #endif.
Need to add FIXME comments.