[webkit-reviews] review requested: [Bug 73544] [EFL] Support for Web Notification. : [Attachment 148240] Patch

[bugzilla-daemon at webkit.org]

Kihong Kwon <kihong.kwon at samsung.com> has asked  for review:
Bug 73544: [EFL] Support for Web Notification.
https://bugs.webkit.org/show_bug.cgi?id=73544

Attachment 148240: Patch
https://bugs.webkit.org/attachment.cgi?id=148240&action=review

------- Additional Comments from Kihong Kwon <kihong.kwon at samsung.com>
> > > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:-24
> > > -#include "NotImplemented.h"
> > 
> > When NOTIFICATION is disabled, there is build break as below,
> > 
> > 86%] Building CXX object
Source/WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/PageClientEfl.cpp.o
> > In file included from
/home/gyuyoung/webkit/WebKit/Source/WebKit/efl/WebCoreSupport/NotificationPrese
nterClientEfl.cpp:21:0:
> >
/home/gyuyoung/webkit/WebKit/Source/WebKit/efl/WebCoreSupport/NotificationPrese
nterClientEfl.h:24:26: fatal error: Notification.h: No such file or directory
> > 
> LEGACY_NOTIFICATION is like a optional feature of NOTIFICATION, therefore
there is no chance to enable LEGACY_NOTIFICATION without NOTIFICAION.
> (there are some link errors from WebCore by WebCore/CMakeLIsts.txt:1703)
> But I will change this.

If I fix this, we need to change position of "${WEBCORE_DIR}/notifications" in
the platformEfl.txt

>From : 
IF (ENABLE_NOTIFICATIONS)
  LIST(APPEND WebKit_INCLUDE_DIRECTORIES
    "${WEBCORE_DIR}/notifications"
  )
ENDIF ()

To :
  LIST(APPEND WebKit_INCLUDE_DIRECTORIES
    ...
    "${WEBCORE_DIR}/notifications"
    ...
  )

But, there are remaining errors in the WebCore as I said above.
Therefore, I don't want to change this now.
When ENABLE_NOTIFICATION feature is deleted for enabling by default, we can
change this.