[webkit-reviews] review granted: [Bug 89400] GCActivityCallback and IncrementalSweeper should share code : [Attachment 148216] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 89400: GCActivityCallback and IncrementalSweeper should share code
https://bugs.webkit.org/show_bug.cgi?id=89400

Attachment 148216: Patch
https://bugs.webkit.org/attachment.cgi?id=148216&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148216&action=review


r=me

> Source/JavaScriptCore/runtime/ExternalVMAgent.h:14
> +class ExternalVMAgent {

This name seemed a bit vague to me. "External" isn't just says what you're not
(i.e., not internal), and "VM" doesn't specifically convey "related to the GC
heap".

How about HeapTimer or ScheduledHeapAgent?