[webkit-reviews] review granted: [Bug 87029] Expose WEBGL_depth_texture extension to WebGL : [Attachment 148156] Patch

Mon Jun 18 18:20:56 PDT 2012

Kenneth Russell <kbr at google.com> has granted Gregg Tavares <gman at google.com>'s
request for review:
Bug 87029: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029

Attachment 148156: Patch
https://bugs.webkit.org/attachment.cgi?id=148156&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148156&action=review

Looks great overall. Nice test. Two minor questions. Marking r+, but not
touching cq bit in case you want or need to address either.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3560
> +								border, format,
type, m_unpackAlignment);

A little subtle given the offline discussions about ANGLE_depth_texture and the
fact that it can't upload data to the texture. Is it worth a comment here that
on some platforms, it may be tricky to implement initialization of depth or
depth/stencil textures?

> LayoutTests/fast/canvas/webgl/webgl-depth-texture.html:1
> +ï»¿<!DOCTYPE html>

Are there a few garbage characters here?