[webkit-reviews] review granted: [Bug 89396] Show TOT revision in garden-o-matic, and make the revisions into links : [Attachment 148213] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 89396: Show TOT revision in garden-o-matic, and make the revisions into
links
https://bugs.webkit.org/show_bug.cgi?id=89396

Attachment 148213: Patch
https://bugs.webkit.org/attachment.cgi?id=148213&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148213&action=review


Thanks.  Sorry about the overhead of the (lame) HTML-based unit tests.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/garden-o-matic.js:85
> +	       function markupForRevision(revision)
> +	       {
> +		   return '<a href=' + trac.changesetURL(revision) + '>' +
revision + '</a>';
> +	       }

This function seems unused now.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui/notifications.js:91
> +	   // this._what.removeAllChildren();

Please remove commented out code.