[webkit-reviews] review granted: [Bug 89098] Add methods to select between offsets in an editable field. : [Attachment 147835] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Oli Lan <olilan at chromium.org>'s
request for review:
Bug 89098: Add methods to select between offsets in an editable field.
https://bugs.webkit.org/show_bug.cgi?id=89098

Attachment 147835: Patch
https://bugs.webkit.org/attachment.cgi?id=147835&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147835&action=review


r=me provided the following nits are addressed.

> Source/WebCore/editing/Editor.cpp:2352
> +    Element* rootEditable = m_frame->selection()->rootEditableElement();

Nit: root editable what? "editable" is an adjective, not a noun. I'd prefer
spelling out rootEditableElement. Element is fine as well.

> Source/WebCore/editing/Editor.cpp:2360
> +    return m_frame->selection()->setSelectedRange(range.get(),
WebCore::VP_DEFAULT_AFFINITY, false);

Nit: No need for WebCore::