[webkit-reviews] review granted: [Bug 89362] [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior : [Attachment 148130] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 89362: [garden-o-matic] Builder names without underscores cause incorrect
BuildSelector behavior
https://bugs.webkit.org/show_bug.cgi?id=89362

Attachment 148130: Patch
https://bugs.webkit.org/attachment.cgi?id=148130&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148130&action=review


> Tools/ChangeLog:12
> +	   (.):

Remove this.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui/results.js:370
> +	       var builderHash = builderName.replace(/[ .()]/g, '_');

This looks very similar to config.resultsDirectoryNameFromBuilderName() for
chromium. Maybe put a function in base and call it in both places.