[webkit-reviews] review granted: [Bug 89216] RenderView layer is marked as fixed position container if page scale != 1 : [Attachment 148101] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sami Kyostila
<skyostil at google.com>'s request for review:
Bug 89216: RenderView layer is marked as fixed position container if page scale
!= 1
https://bugs.webkit.org/show_bug.cgi?id=89216

Attachment 148101: Patch
https://bugs.webkit.org/attachment.cgi?id=148101&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148101&action=review


> Source/WebCore/ChangeLog:3
> +	   RenderView layer is marked as fixed position container if page scale
!= 1

Normally when we talked about "fixed position containers", we're talking about
the render tree, but this bug only exists in the scrolling tree. The bug title
should say this.

> Source/WebCore/ChangeLog:22
> +	   This patch also adds a testing framework for ScrollingCoordinator.
Layout
> +	   tests can call testRunner.scrollingTreeAsText() to retrieve a text
> +	   representation of the scrolling tree of the current page. This
feature is
> +	   currently only implemented for the Chromium scrolling coordinator
back-end.

Do you think that the scrolling tree output is comparable across
implementations? If not, the utility of this way of testing is reduced.

>
LayoutTests/platform/chromium/compositing/fixed-position-container-with-page-sc
ale.html:22
> +	   testRunner.dumpAsText(true);

Why dumpAsText(true)? The pixel result doesn't seem useful.