[webkit-reviews] review denied: [Bug 87844] Implement painting slider tick marks : [Attachment 148078] Reabsed, used HTMLInputElement::sliderThumbElement, fixed Qt build.

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 87844: Implement painting slider tick marks
https://bugs.webkit.org/show_bug.cgi?id=87844

Attachment 148078: Reabsed, used HTMLInputElement::sliderThumbElement, fixed Qt
build.
https://bugs.webkit.org/attachment.cgi?id=148078&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148078&action=review


The code looks good.  But the patch looks broken. r- because of purple EWS

> LayoutTests/fast/forms/range/slider-zoomed-expected.txt:2
> -PASS: slider value set to 72
> +FAIL: expected slider value 72, got 71

Is this related to this bug?

>
LayoutTests/platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-upda
te-expected.txt:-1
> -layer at (0,0) size 800x600

ditto.

>
LayoutTests/platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-upda
te-styled-expected.txt:-1
> -layer at (0,0) size 800x600

ditto.

>
LayoutTests/platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expe
cted.txt:-2
> -  RenderView at (0,0) size 800x600

ditto.

>
LayoutTests/platform/chromium-linux/fast/repaint/slider-thumb-float-expected.tx
t:-1
> -layer at (0,0) size 800x600

ditto.

>
LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update
-expected.txt:6
> -	 RenderSlider {INPUT} at (2,2) size 129x21 [color=#C4C4C4]
[bgcolor=#FFFFFF]
> +	 RenderSlider {INPUT} at (2,2) size 129x21 [bgcolor=#FFFFFF]

ditto.

>
LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-drag-release-expect
ed.txt:6
> -	 RenderSlider {INPUT} at (2,2) size 129x21 [color=#C4C4C4]
[bgcolor=#FFFFFF]
> +	 RenderSlider {INPUT} at (2,2) size 129x21 [bgcolor=#FFFFFF]

ditto.

> Source/WebCore/rendering/RenderTheme.cpp:1023
> +	   if (!o->style()->isLeftToRightDirection())
> +	     tickPosition = 1.0 - tickPosition;

wrong indentation

> Source/WebCore/rendering/RenderThemeChromiumWin.cpp:475
> +    PlatformSupport::paintTrackbar(painter.context(),
> +				     themeData.m_part,
> +				     themeData.m_state,
> +				     themeData.m_classicState,
> +				     painter.drawRect());

inconsistent indentation.