[webkit-reviews] review granted: [Bug 89307] Web Inspector: Make text in WebSocket Frames tab selectable : [Attachment 148012] A fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 18 00:00:12 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Nikita Vasilyev
<me at elv1s.ru>'s request for review:
Bug 89307: Web Inspector: Make text in WebSocket Frames tab selectable
https://bugs.webkit.org/show_bug.cgi?id=89307

Attachment 148012: A fix
https://bugs.webkit.org/attachment.cgi?id=148012&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148012&action=review


>> Source/WebCore/inspector/front-end/ResourceWebSocketFrameView.js:-26
>> -	this.element.addStyleClass("html");
> 
> "html" class doesn’t seem to be used.
> 
> Should I use classList.add instead of addStyleClass? The latter is just a
shortcut for the former but it has the same amount of characters. There is a
bug related to it https://bugs.webkit.org/show_bug.cgi?id=72803

It is OK to use addStyleClass here at the moment for consistency, we will
switch the whole file to classList.add at once.


More information about the webkit-reviews mailing list