[webkit-reviews] review granted: [Bug 89320] Fix Framebuffer restrictions : [Attachment 148035] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Gregg Tavares <gman at google.com>'s
request for review:
Bug 89320: Fix Framebuffer restrictions
https://bugs.webkit.org/show_bug.cgi?id=89320

Attachment 148035: Patch
https://bugs.webkit.org/attachment.cgi?id=148035&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks good; thanks for tracking this down.

It looks like framebuffer-object-attachment.html was skipped on the Mac
platform in https://bugs.webkit.org/show_bug.cgi?id=82805 and this might be why
this slipped through the cracks on the Mac platform.

Could you take a look through the results of
platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt ? It
looks to me like it is returning FRAMEBUFFER_COMPLETE in one case where the
platform-independent results in
fast/canvas/webgl/framebuffer-object-attachment-expected.txt return
FRAMEBUFFER_UNSUPPORTED. Also, there are a couple of platform-specific expected
results (platform/chromium-mac-snowleopard, platform/mac-snowleopard) which are
identical to the platform-independent results and which could be deleted.