[webkit-reviews] review denied: [Bug 87844] Implement painting slider tick marks : [Attachment 147507] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 17 22:38:06 PDT 2012
Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 87844: Implement painting slider tick marks
https://bugs.webkit.org/show_bug.cgi?id=87844
Attachment 147507: Patch
https://bugs.webkit.org/attachment.cgi?id=147507&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147507&action=review
r- because we need rebase.
> Source/WebCore/html/shadow/SliderThumbElement.cpp:150
> + RenderObject* thumbRenderer =
input->shadow()->oldestShadowRoot()->firstChild()->firstChild()->firstChild()->
renderer();
We had better use sliderThumbElement().
More information about the webkit-reviews
mailing list