[webkit-reviews] review granted: [Bug 89321] Move functions to create strings from integers out of JavaScriptCore and into WTF : [Attachment 148037] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 89321: Move functions to create strings from integers out of JavaScriptCore
and into WTF
https://bugs.webkit.org/show_bug.cgi?id=89321

Attachment 148037: Patch
https://bugs.webkit.org/attachment.cgi?id=148037&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Please fix Windows export:

17>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external
symbol "public: static class WTF::PassRefPtr<class WTF::StringImpl> __cdecl
WTF::StringImpl::createNumeral(unsigned long)"
(?createNumeral at StringImpl@WTF@@SA?AV?$PassRefPtr at VStringImpl@WTF@@@2 at K@Z)
referenced in function "public: static class WTF::PassRefPtr<class
WTF::StringImpl> __cdecl WTF::StringImpl::createNumeral(unsigned int)"
(?createNumeral at StringImpl@WTF@@SA?AV?$PassRefPtr at VStringImpl@WTF@@@2 at I@Z)

r=me