[webkit-reviews] review granted: [Bug 89310] garden-o-matic 'Results' panel is broken for the Apple platform : [Attachment 148022] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 89310: garden-o-matic 'Results' panel is broken for the Apple platform
https://bugs.webkit.org/show_bug.cgi?id=89310

Attachment 148022: Patch
https://bugs.webkit.org/attachment.cgi?id=148022&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148022&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/results.js:614
> +	   $.each(suffixList, function(index, suffix) {
> +	       var url = stem + testNameStem + suffix;
> +	       net.probe(url, {
> +		   success: function() {
> +		       resultURLs.push(url);
> +		       tracker.requestComplete();
> +		   },
> +		   error: function() {
> +		       tracker.requestComplete();
> +		   },
> +	       });

This part looks duplicated.  I wonder if we can pull this out of both sides of
the if statement and share it.