[webkit-reviews] review denied: [Bug 89277] [Texmap] Share gaussian formula between shaders in TextureMapperShaderManager. : [Attachment 147958] patch v.1

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 89277: [Texmap] Share gaussian formula between shaders in
TextureMapperShaderManager.
https://bugs.webkit.org/show_bug.cgi?id=89277

Attachment 147958: patch v.1
https://bugs.webkit.org/attachment.cgi?id=147958&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147958&action=review


> Source/WebCore/ChangeLog:8
> +	   [Texmap] Share gaussian formula between shaders in
TextureMapperShaderManager.
> +	   https://bugs.webkit.org/show_bug.cgi?id=89277
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new tests. This patch doesn't change behavior.

You're doing a lot more than that, actually moving to a more accurate gaussian
blur...
I like that, but please describe in the Changelog.

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:672
> +	   }
> +	   // Normalize the kernel

Extra line

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:678
> +    }
> +    return kernel;

Extra line