[webkit-reviews] review granted: [Bug 88916] [chromium] Make the deviceScaleFactor dynamically adjustable. : [Attachment 147884] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 88916: [chromium] Make the deviceScaleFactor dynamically adjustable.
https://bugs.webkit.org/show_bug.cgi?id=88916

Attachment 147884: Patch
https://bugs.webkit.org/attachment.cgi?id=147884&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147884&action=review


R=me

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:579
> +void CCLayerTreeHostImpl::setDeviceScaleFactor(float newDeviceScaleFactor)
> +{
> +    if (newDeviceScaleFactor == deviceScaleFactor())

IMO this is bad style - what you had in CCLayerTreeHost::setDeviceScaleFactor()
is better. using the member var directly makes it much clearer what is going on
to readers and avoids having the ugly "new" prefix on a variable name