[webkit-reviews] review denied: [Bug 89258] [Chromium] Ensure layout has happened before calling into hasNonEmptyBoundingBox() : [Attachment 147929] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 15 18:13:28 PDT 2012
James Robinson <jamesr at chromium.org> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 89258: [Chromium] Ensure layout has happened before calling into
hasNonEmptyBoundingBox()
https://bugs.webkit.org/show_bug.cgi?id=89258
Attachment 147929: Patch
https://bugs.webkit.org/attachment.cgi?id=147929&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147929&action=review
> Source/WebKit/chromium/src/WebNode.cpp:218
> + m_private->document()->updateLayout();
most code in WebCore of this nature calls
updateLayoutIgnorePendingStylesheets() - it deals with a
m_hasNodesWithPlaceholderStyle case that seems important
More information about the webkit-reviews
mailing list