[webkit-reviews] review denied: [Bug 89253] Makes ImageDiff reflect size of pixel delta in the alpha channel of the resulting red pixel. : [Attachment 147916] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 15 16:07:17 PDT 2012


James Robinson <jamesr at chromium.org> has denied Tony Payne
<tpayne at chromium.org>'s request for review:
Bug 89253: Makes ImageDiff reflect size of pixel delta in the alpha channel of
the resulting red pixel.
https://bugs.webkit.org/show_bug.cgi?id=89253

Attachment 147916: Patch
https://bugs.webkit.org/attachment.cgi?id=147916&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Yeah, that's pretty but it's too hard to tell from a non-failure for gardening
use IMO.  I also don't want to have different behaviors for chromium ImageDiff
vs "normal" ImageDiff.

Some sort of flag or option, perhaps?


More information about the webkit-reviews mailing list