[webkit-reviews] review denied: [Bug 89228] [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory : [Attachment 147913] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 15 15:46:17 PDT 2012


Tony Chang <tony at chromium.org> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 89228: [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of
linuxish directory
https://bugs.webkit.org/show_bug.cgi?id=89228

Attachment 147913: patch v2
https://bugs.webkit.org/attachment.cgi?id=147913&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147913&action=review


> Source/WebCore/ChangeLog:13
> +	   * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
> +	   (WebCore::FontPlatformData::setupPaint):
> +	   * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
> +	   (FontPlatformData):

Please describe your changes here.

> Source/WebKit/chromium/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * WebKit.gyp:
> +	   * public/WebFontRendering.h: Copied from
Source/WebKit/chromium/public/linuxish/WebFontRendering.h.

Please provide an overview of what is happening. I would probably use the word
refactor in the description.

> Source/WebKit/chromium/public/WebFontRendering.h:61
> +    static SkPaint::Hinting getHinting();
> +    static bool getAutoHint();
> +    static bool getUseBitmaps();
> +    static bool getAntiAlias();
> +    static bool getSubpixelRendering();
> +    static bool getSubpixelPositioning();

We normally don't prefix functions with 'get' in WebKit code.


More information about the webkit-reviews mailing list