[webkit-reviews] review denied: [Bug 89238] Accumulate sub-pixel offsets through layers and transforms : [Attachment 147890] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 89238: Accumulate sub-pixel offsets through layers and transforms
https://bugs.webkit.org/show_bug.cgi?id=89238

Attachment 147890: Patch
https://bugs.webkit.org/attachment.cgi?id=147890&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147890&action=review


r- for boolean params. When do you NOT want to pixel snap when mapping coords?

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:699
> +    IntRect box = IntRect(sizingBox(renderer, true));

Gah, ugly boolean params!