[webkit-reviews] review granted: [Bug 89185] AssociatedURLLoader should allow trusted clients to read all headers, not just exposed ones : [Attachment 147806] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 89185: AssociatedURLLoader should allow trusted clients to read all
headers, not just exposed ones
https://bugs.webkit.org/show_bug.cgi?id=89185

Attachment 147806: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=147806&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147806&action=review


Interesting approach.  I was expecting you to add another function for grabbing
the headers, but I see why you've taken this approach.

> Source/WebKit/chromium/public/WebURLLoaderOptions.h:57
> +    bool allowResponseHeaders; // If policy is to use access control,
whether to allow non-simple response headers.

I wonder if we should name this something like exposeAllResponseHeaders to
mimic the name of Access-Control-Expose-Headers ?