[webkit-reviews] review granted: [Bug 74976] Element still flowed below parent after changing from block to inline-block : [Attachment 147391] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Abhishek Arya
<inferno at chromium.org>'s request for review:
Bug 74976: Element still flowed below parent after changing from block to
inline-block
https://bugs.webkit.org/show_bug.cgi?id=74976

Attachment 147391: Patch
https://bugs.webkit.org/attachment.cgi?id=147391&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147391&action=review


Still not a super fan of blowing up |this| during removeChild but let's see how
it turns out.

> Source/WebCore/rendering/RenderBlock.cpp:1240
> +	       RenderBoxModelObject* nextContinuation = continuation();

You could move the variable in the |for| loop as it's only used if you find
your previous continuation.

> LayoutTests/platform/mac/TestExpectations:263
> +BUG_INFERNO : fast/invalid/007.html = TEXT

Why do you use BUG_INFERNO here. It should point to this bug at least
(WK74976).

Some people advocate not touching expectations if you think you will stay on
top of the bots and do the rebaseline, which is also fine by me.