[webkit-reviews] review denied: [Bug 89061] applyAuthorStyles makes rules declared in all enclosing shadow dom subtrees applicable. : [Attachment 147752] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 89061: applyAuthorStyles makes rules declared in all enclosing shadow dom
subtrees applicable.
https://bugs.webkit.org/show_bug.cgi?id=89061

Attachment 147752: Patch
https://bugs.webkit.org/attachment.cgi?id=147752&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147752&action=review


getting really close now.

Thank you for the explanation!

> Source/WebCore/css/StyleResolver.cpp:952
> +    if (m_element->isInShadowTree() && !m_scopeStack.isEmpty()) {

Looks like early return would improve readability here.

> Source/WebCore/css/StyleResolver.h:534
> +	   ScopeStackFrame() : m_scope(0), m_scopeGroup(0), m_ruleSet(0) { }

It's a scope index, right? Not scope group. What you're doing here is storing
the actual index of the stack, creating a virtual sparse array.