[webkit-reviews] review granted: [Bug 89211] [BlackBerry] Certain web pages (i.e., http://www.cloudtweaks.com/) are allowed to be wider than the screen : [Attachment 147829] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 15 09:26:06 PDT 2012
Rob Buis <rwlbuis at gmail.com> has granted Jacky Jiang <jkjiang at webkit.org>'s
request for review:
Bug 89211: [BlackBerry] Certain web pages (i.e., http://www.cloudtweaks.com/)
are allowed to be wider than the screen
https://bugs.webkit.org/show_bug.cgi?id=89211
Attachment 147829: Patch
https://bugs.webkit.org/attachment.cgi?id=147829&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147829&action=review
LGTM.
> Source/WebKit/blackberry/Api/WebPage.cpp:1683
> + return zoomToFitScale < minimumZoomToFitScale ? minimumZoomToFitScale :
zoomToFitScale;
Using std:min is better here as it is clearer what you are doing.
More information about the webkit-reviews
mailing list