[webkit-reviews] review granted: [Bug 89126] [chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html : [Attachment 147651] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 89126: [chromium] Fix
LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html
https://bugs.webkit.org/show_bug.cgi?id=89126

Attachment 147651: Patch
https://bugs.webkit.org/attachment.cgi?id=147651&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147651&action=review


Thanks for fixing this.  r=me

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:179
> +    // If we're rendering into a deferred device, we need to make a deep
copy of the source pixels because Skia does not
> +    // retain a reference to the actual pixels otherwise. We check if we're
drawing into a deferred device by seeing if the

Nit:  Technically, it's a deferred canvas, not a deferred device
(SkPicture::beginRecording() returns an SkPictureRecord, which is a subclass of
SkCanvas).