[webkit-reviews] review granted: [Bug 88500] [Crash][Editing] VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries() crashes in some Shadow DOM case : [Attachment 147727] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 15 01:53:37 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 88500: [Crash][Editing]
VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries() crashes in
some Shadow DOM case
https://bugs.webkit.org/show_bug.cgi?id=88500

Attachment 147727: Patch
https://bugs.webkit.org/attachment.cgi?id=147727&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147727&action=review


> LayoutTests/editing/shadow/breaking-editing-boundaries.html:12
> +    BEFORE<span id="host" contenteditable="false">DRAG FROM HERE<span
id="target"> </span>FOO BAR</span>

Nit: ALL CAPS DON'T READ WELL. Please use normal capitalization.


More information about the webkit-reviews mailing list