[webkit-reviews] review denied: [Bug 89176] Use testRunner instead of layoutTestController in ietestcenter, inspector, java, jquery, loader, mathml, media, and mhtml tests : [Attachment 147746] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 89176: Use testRunner instead of layoutTestController in ietestcenter,
inspector, java, jquery, loader, mathml, media, and mhtml tests
https://bugs.webkit.org/show_bug.cgi?id=89176

Attachment 147746: Patch
https://bugs.webkit.org/attachment.cgi?id=147746&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147746&action=review


> LayoutTests/ChangeLog:162
> +	   * mhtml/check_domain.mht:
> +	   * mhtml/frame_4.html_original:
> +	   * mhtml/multi_frames.html_original:
> +	   * mhtml/multi_frames_binary.mht:
> +	   * mhtml/multi_frames_ie.mht:
> +	   * mhtml/multi_frames_unmht.mht:
> +	   * mhtml/page_with_css_and_js_ie.mht:
> +	   * mhtml/page_with_css_and_js_unmht.mht:
> +	   * mhtml/page_with_image.html_original:
> +	   * mhtml/page_with_image_ie.mht:
> +	   * mhtml/page_with_image_unmht.mht:
> +	   * mhtml/simple_page.html_original:
> +	   * mhtml/simple_page_ie.mht:
> +	   * mhtml/simple_page_unmht.mht:

Do you need to update them?

> LayoutTests/ChangeLog:166
> +	   * platform/chromium/media/resources/frame_size_change.webm:

Do you need to update webm!?

> LayoutTests/media/resources/foreignobject-media.svg:14
> -</svg>
>  \ No newline at end of file
> +</svg>

Looks unrelated.

> LayoutTests/media/track/track-webvtt-tc001-utf8.html:76
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc004-magic-header.html:77
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc005-header-comment.html:60
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc006-cue-identifiers.html:76
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc007-cue-no-id.html:76
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html:75
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc011-blank-lines.html:75
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc013-settings.html:85
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc014-alignment.html:70
> -</html>
>  \ No newline at end of file
> +</html>

ditto.

> LayoutTests/media/track/track-webvtt-tc015-positioning.html:70
> -</html>
>  \ No newline at end of file
> +</html>

ditto.