[webkit-reviews] review denied: [Bug 88980] [Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine : [Attachment 147741] Patch 6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 23:32:53 PDT 2012


Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 88980: [Forms] Move search field related code to RenderSearchField from
RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=88980

Attachment 147741: Patch 6
https://bugs.webkit.org/attachment.cgi?id=147741&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147741&action=review


> Source/WebCore/rendering/RenderSearchField.cpp:-448
> -LayoutUnit RenderTextControlSingleLine::computeControlHeight(LayoutUnit
lineHeight, LayoutUnit nonContentHeight) const
> -{
> -    HTMLElement* resultsButton = resultsButtonElement();
> -    if (RenderBox* resultsRenderer = resultsButton ?
resultsButton->renderBox() : 0) {
> -	   resultsRenderer->computeLogicalHeight();
> -	   nonContentHeight = max(nonContentHeight,
resultsRenderer->borderAndPaddingHeight() + resultsRenderer->marginHeight());
> -	   lineHeight = max(lineHeight, resultsRenderer->height());
> -    }
> -    HTMLElement* cancelButton = cancelButtonElement();
> -    if (RenderBox* cancelRenderer = cancelButton ? cancelButton->renderBox()
: 0) {
> -	   cancelRenderer->computeLogicalHeight();
> -	   nonContentHeight = max(nonContentHeight,
cancelRenderer->borderAndPaddingHeight() + cancelRenderer->marginHeight());
> -	   lineHeight = max(lineHeight, cancelRenderer->height());
> -    }
> -
> -    return lineHeight + nonContentHeight;
> -}

resultsButtonElement() and cancelButtonElement() are search-specific elements. 
This function should not be removed.

> Source/WebCore/rendering/RenderSearchField.cpp:-518
> -void RenderTextControlSingleLine::updateCancelButtonVisibility() const
> -{
> -    RenderObject* cancelButtonRenderer = cancelButtonElement()->renderer();
> -    if (!cancelButtonRenderer)
> -	   return;
> -
> -    const RenderStyle* curStyle = cancelButtonRenderer->style();
> -    EVisibility buttonVisibility = visibilityForCancelButton();
> -    if (curStyle->visibility() == buttonVisibility)
> -	   return;
> -
> -    RefPtr<RenderStyle> cancelButtonStyle = RenderStyle::clone(curStyle);
> -    cancelButtonStyle->setVisibility(buttonVisibility);
> -    cancelButtonRenderer->setStyle(cancelButtonStyle);
> -}
> -
> -EVisibility RenderTextControlSingleLine::visibilityForCancelButton() const
> -{
> -    return (style()->visibility() == HIDDEN ||
inputElement()->value().isEmpty()) ? HIDDEN : VISIBLE;
> -}

cancelButtonElement() is search-specific.  This should not be removed.

> Source/WebCore/rendering/RenderSearchField.cpp:-529
> -const AtomicString& RenderTextControlSingleLine::autosaveName() const
> -{
> -    return static_cast<Element*>(node())->getAttribute(autosaveAttr);
> -}

autosaveName() is search-specific.  This should not be removed.


More information about the webkit-reviews mailing list