[webkit-reviews] review granted: [Bug 61152] [Resource Timing] Implement Resource Timing interface : [Attachment 147721] Patch

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 61152: [Resource Timing] Implement Resource Timing interface
https://bugs.webkit.org/show_bug.cgi?id=61152

Attachment 147721: Patch
https://bugs.webkit.org/attachment.cgi?id=147721&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147721&action=review


> Source/WebCore/ChangeLog:12611
> +2012-04-25  James Simonsen  <simonjam at chromium.org>

Merge problem

> Source/WebCore/page/PerformanceResourceTiming.cpp:107
> +	   connectStart = m_timing->dnsEnd;

A lot of these conditions remind me of similar ones in Navigation Timing that
should probably stay in sync in the future.

I don't have a specific suggestion, but Is there any reasonable way to factor
out any commonality between the two?