[webkit-reviews] review granted: [Bug 88916] [chromium] Make the deviceScaleFactor dynamically adjustable. : [Attachment 147694] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 88916: [chromium] Make the deviceScaleFactor dynamically adjustable.
https://bugs.webkit.org/show_bug.cgi?id=88916

Attachment 147694: Patch
https://bugs.webkit.org/attachment.cgi?id=147694&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147694&action=review


R=me, few nits to clean up (mostly unnecessary consts on scalar parameters).

> Source/Platform/chromium/public/WebLayerTreeView.h:116
> +    WEBKIT_EXPORT void setDeviceScaleFactor(const float);

no const

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:689
> +void CCLayerTreeHost::setDeviceScaleFactor(const float deviceScaleFactor)

no const

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:254
> +    // Dynamic setting of the deviceScaleFactor.

This comment's kind of silly, what does it tell the reader that they wouldn't
already know? I would just remove it.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:255
> +    void setDeviceScaleFactor(const float);

no const on a scalar parameter - it's passed by value anyway

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:577
> +void CCLayerTreeHostImpl::setDeviceScaleFactor(const float
newDeviceScaleFactor)

no const

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:154
> +    void setDeviceScaleFactor(const float);

no const