[webkit-reviews] review granted: [Bug 88940] DrawingArea: Painting is being resumed while the view is not visible : [Attachment 147676] patch, name is no better, changelog is improved

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 88940: DrawingArea: Painting is being resumed while the view is not visible
https://bugs.webkit.org/show_bug.cgi?id=88940

Attachment 147676: patch, name is no better, changelog is improved
https://bugs.webkit.org/attachment.cgi?id=147676&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147676&action=review


Great changelog.

Still don't like the name. Maybe suspendPaintingWhileWindowHostingChanges ?
Marking r+ and we can work out the name on irc.

> Source/WebKit2/ChangeLog:10
> +	   would cause rAF to permanently suspend animations when fullscreened,
because of the following:

I would invent a word like "fullscreened" in my own patch, but in review I must
strangely request something like "when the page is made fullscreen" :)