[webkit-reviews] review denied: [Bug 79914] The initial value of text-align should be start instead of -webkit-auto : [Attachment 147658] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 79914: The initial value of text-align should be start instead of
-webkit-auto
https://bugs.webkit.org/show_bug.cgi?id=79914

Attachment 147658: Patch
https://bugs.webkit.org/attachment.cgi?id=147658&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147658&action=review


r- because GTK compile failure.

> Source/WebCore/css/StyleResolver.cpp:2065
> +	   // FIXME: We shouldn't be overriding start/-webkit-auto like this.

Maybe mention editing html.css here?

> Source/WebCore/editing/EditingStyle.cpp:913
> +    if (textAlignResolvingStartAndEnd(styleAtPosition) ==
textAlignResolvingStartAndEnd(styleAtPosition))

This will always be true.

> Source/WebCore/rendering/RenderRubyText.cpp:58
> +    // FIXME: This check is bogus since user can set the initial value.
> +    if (textAlign != RenderStyle::initialTextAlign())

Should we file a bug for this?

> LayoutTests/fast/css/text-align-webkit-auto.html:5
>	   window.layoutTestController.dumpAsText();

We might want to rename this test to text-align-initial.html or
text-align-start.html.