[webkit-reviews] review requested: [Bug 89130] avoid min and max check in Color constructor when needed. : [Attachment 147662] patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 15:35:28 PDT 2012


arno. <arno at renevier.net> has asked  for review:
Bug 89130: avoid min and max check in Color constructor when needed.
https://bugs.webkit.org/show_bug.cgi?id=89130

Attachment 147662: patch proposal
https://bugs.webkit.org/attachment.cgi?id=147662&action=review

------- Additional Comments from arno. <arno at renevier.net>
patch proposal. I get a 5% to 15% speedup in
CanvasRenderingContext2D.putImageData in the gtk port. Color constructor does
not seem to be called with signed char nor unsigned int, but makeRGBA is called
with unsigned int. So, I still added Color constructor for char, unsigned char
and unsigned int, just in case


More information about the webkit-reviews mailing list